-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(Table): improve performance for select all on header #4740
Conversation
Reviewer's Guide by SourceryThe changes optimize the performance of the table's select-all functionality by replacing inefficient LINQ operations with more performant alternatives. The main improvements focus on the header checkbox state calculation and the row selection logic. Updated class diagram for Table.razor.Checkbox.csclassDiagram
class Table {
+CheckboxState HeaderCheckState()
+Task OnHeaderCheck(CheckboxState state, TItem val)
}
class CheckboxState {
<<enumeration>>
Checked
Unchecked
Indeterminate
}
Table --> CheckboxState
note for Table "Optimized performance for select-all functionality by modifying LINQ operations."
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4740 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27391 27390 -1
Branches 3921 3921
=========================================
- Hits 27391 27390 -1 ☔ View full report in Codecov by Sentry. |
improve performance for select all on header
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4739
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Improve the performance of the 'select all' feature in the table header by optimizing the logic for checking selected rows and fixing the header checkbox state determination.
Bug Fixes:
Enhancements: