Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(Dialog): add docment for ShowModal dialog service #4748

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Nov 27, 2024

add docment for ShowModal dialog service

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4747

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add documentation for the ShowModal dialog service and update a unit test to ensure correct behavior of the DateTimePicker component.

Documentation:

  • Add documentation for the ShowModal dialog service.

Tests:

  • Modify the DateTimePickerTest to assert that the value is not equal to DateTime.MinValue after clicking a button.

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Nov 27, 2024
Copy link

sourcery-ai bot commented Nov 27, 2024

Reviewer's Guide by Sourcery

This PR updates a unit test for the DateTimePicker component's AutoClose functionality. The test case has been modified to correctly verify that selecting a date updates the value when AutoClose is enabled.

Class diagram for DateTimePickerTest modifications

classDiagram
    class DateTimePickerTest {
        +AutoClose_OK()
    }
    note for DateTimePickerTest "Modified the AutoClose_OK test to correctly verify date selection."
Loading

File-Level Changes

Change Details Files
Fixed DateTimePicker AutoClose unit test logic
  • Added explicit date cell selection before click event
  • Updated assertion to verify value is set after date selection
  • Changed assertion from Equal to NotEqual when comparing with DateTime.MinValue
test/UnitTest/Components/DateTimePickerTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#4747 Add documentation/sample code for ShowModal dialog service The PR only contains changes to a DateTimePicker test file and does not include any documentation or sample code for the ShowModal dialog service as requested in the issue.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.0.0 milestone Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (725ee30) to head (f2b8699).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4748   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27390     27390           
  Branches      3921      3921           
=========================================
  Hits         27390     27390           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 81e8297 into main Nov 27, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the doc-dialog branch November 27, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc(Dialog): add docment for ShowModal dialog service
1 participant