-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Table): ItemChangedType doesn't pass correct value to EditTemplate on Drawer mode #4750
Conversation
Reviewer's Guide by SourceryThe fix addresses an issue where ItemChangedType wasn't being properly passed to EditTemplate in Drawer mode by wrapping the EditDialog content with a CascadingValue component to ensure proper value propagation. Class diagram for EditDialog component changesclassDiagram
class EditDialog {
- BodyTemplate
- Model
- DisableAutoSubmitFormByEnter
- Items
- ItemChangedType
- ItemsPerRow
- RowType
- LabelAlign
- ShowLabel
- ShowUnsetGroupItemsOnTop
+ OnValidSubmitAsync
+ RenderFooter
}
class CascadingValue {
+ Value
+ IsFixed
}
EditDialog --> CascadingValue : wraps content
CascadingValue --> EditTemplate : ensures value propagation
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4750 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27390 27390
Branches 3921 3921
=========================================
Hits 27390 27390 ☔ View full report in Codecov by Sentry. |
ItemChangedType doesn't pass correct value to EditTemplate on Drawer mode
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4721
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: