Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): ItemChangedType doesn't pass correct value to EditTemplate on Drawer mode #4750

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Nov 28, 2024

ItemChangedType doesn't pass correct value to EditTemplate on Drawer mode

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4721

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fix the issue where ItemChangedType does not pass the correct value to EditTemplate in Drawer mode by wrapping the form content in a CascadingValue component.

Copy link

sourcery-ai bot commented Nov 28, 2024

Reviewer's Guide by Sourcery

The fix addresses an issue where ItemChangedType wasn't being properly passed to EditTemplate in Drawer mode by wrapping the EditDialog content with a CascadingValue component to ensure proper value propagation.

Class diagram for EditDialog component changes

classDiagram
    class EditDialog {
        - BodyTemplate
        - Model
        - DisableAutoSubmitFormByEnter
        - Items
        - ItemChangedType
        - ItemsPerRow
        - RowType
        - LabelAlign
        - ShowLabel
        - ShowUnsetGroupItemsOnTop
        + OnValidSubmitAsync
        + RenderFooter
    }
    class CascadingValue {
        + Value
        + IsFixed
    }
    EditDialog --> CascadingValue : wraps content
    CascadingValue --> EditTemplate : ensures value propagation
Loading

File-Level Changes

Change Details Files
Added CascadingValue component to properly propagate ItemChangedType
  • Wrapped the entire EditDialog content with CascadingValue component
  • Set ItemChangedType as the cascading value
  • Added IsFixed=true to optimize the cascading parameter updates
src/BootstrapBlazor/Components/Dialog/EditDialog.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#4721 Fix ItemChangedType to pass the correct value (ItemChangedType.Update) to EditTemplate when clicking the edit button in Table component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Nov 28, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Nov 28, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (81e8297) to head (4006a8f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4750   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27390     27390           
  Branches      3921      3921           
=========================================
  Hits         27390     27390           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 341ffda into main Nov 28, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-table branch November 28, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the ItemChangedType doesn't pass correct value to it's EditTemplate
1 participant