-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Table): add OnAfterCancelSaveAsync parameter #4757
Conversation
Reviewer's Guide by SourceryThis PR adds a new OnAfterCancelSaveAsync callback parameter to the Table component, which is triggered when a user cancels saving changes in either Popup or Drawer edit modes. The implementation includes unit tests to verify the callback behavior in both modes. Class diagram for the updated Table componentclassDiagram
class Table {
+Func<Task> OnAfterCancelSaveAsync
}
note for Table "New parameter OnAfterCancelSaveAsync added to handle post-cancel save actions."
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The OnAfterCancelSaveAsync callback behavior is inconsistent between popup and drawer modes. In popup mode it won't trigger after a successful save, but in drawer mode it will. Consider adding the same triggerFromSave check in the drawer implementation to match the popup behavior.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4757 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27390 27407 +17
Branches 3921 3923 +2
=========================================
+ Hits 27390 27407 +17 ☔ View full report in Codecov by Sentry. |
add OnAfterCancelSaveAsync parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4749
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add the OnAfterCancelSaveAsync parameter to the Table component to enable custom actions after a cancel save operation, and implement corresponding unit tests to verify its functionality.
New Features:
Tests: