Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(Topology): update javascript path #4769

Merged
merged 3 commits into from
Dec 1, 2024
Merged

doc(Topology): update javascript path #4769

merged 3 commits into from
Dec 1, 2024

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Dec 1, 2024

update javascript path

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4768

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update JavaScript and image paths in the Topologies component to fix loading issues and ensure correct file referencing.

Bug Fixes:

  • Correct the JavaScript module path in the Topologies.razor component to ensure proper loading.

Documentation:

  • Update image paths in topology.json to reflect the correct directory structure.

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Dec 1, 2024
Copy link

sourcery-ai bot commented Dec 1, 2024

Reviewer's Guide by Sourcery

The PR updates the file paths in the topology configuration and component to correctly reference JavaScript and image assets using the _content convention for Blazor static files.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated image paths in topology configuration to use Blazor's _content convention
  • Changed fan.gif path to include _content prefix
  • Changed fan.svg path to include _content prefix
src/BootstrapBlazor.Shared/topology.json
Updated JavaScript module path in Topologies component
  • Modified JSModuleAutoLoader path to correctly reference the component's JS file under Components/Samples directory
src/BootstrapBlazor.Shared/Components/Samples/Topologies.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#4768 Update JavaScript and asset paths in Topology component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 1, 2024
@ArgoZhang ArgoZhang enabled auto-merge (squash) December 1, 2024 13:18
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang disabled auto-merge December 1, 2024 13:22
@ArgoZhang ArgoZhang merged commit e9a7076 into main Dec 1, 2024
2 of 3 checks passed
@ArgoZhang ArgoZhang deleted the refactor-js branch December 1, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc(Topology): update javascript path
1 participant