Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(Sample): update static assets path #4771

Merged
merged 6 commits into from
Dec 2, 2024
Merged

doc(Sample): update static assets path #4771

merged 6 commits into from
Dec 2, 2024

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Dec 2, 2024

update static assets path

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4770

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update static asset paths across multiple components to ensure correct file referencing, and adjust the nullable reference type for a property in the Collapses component.

Bug Fixes:

  • Correct the static asset paths in various components to ensure proper loading of images and scripts.

Enhancements:

  • Update the nullable reference type for the 'Value' property in the Collapses component.

Copy link

sourcery-ai bot commented Dec 2, 2024

Reviewer's Guide by Sourcery

This PR updates the static assets path across multiple components to use the standardized _content path prefix for Blazor static files. The changes also include path adjustments for debug/release configurations in the WaterfallController and a minor type update in Collapses.razor.cs.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated static asset paths to use the standardized _content prefix
  • Changed image paths to use ./_content/BootstrapBlazor.Shared/images/
  • Updated MouseFollower component image references
  • Modified intersection observer image paths
  • Updated JSModuleAutoLoader path
src/BootstrapBlazor.Shared/Components/Samples/MouseFollowers.razor
src/BootstrapBlazor.Shared/Components/Samples/IntersectionObservers.razor.cs
src/BootstrapBlazor.Shared/Components/Samples/Tutorials/DrawingApp.razor
Implemented environment-specific file path handling in WaterfallController
  • Added conditional path resolution for DEBUG and release builds
  • Updated base path construction to use AppContext.BaseDirectory in release mode
src/BootstrapBlazor.Server/Controllers/WaterfallController.cs
Made Value property nullable in Collapses component
  • Added nullable annotation to Value property
src/BootstrapBlazor.Shared/Components/Samples/Collapses.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#4770 Update static assets paths in the codebase

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Dec 2, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 2, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a consistent path resolution strategy instead of different paths for DEBUG/release builds in WaterfallController. This could help avoid potential deployment issues and simplify maintenance.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit b9869e9 into main Dec 2, 2024
2 of 3 checks passed
@ArgoZhang ArgoZhang deleted the doc-sample branch December 2, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc(Sample): update static assets path
1 participant