-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(StaticAsset): use WebsiteOption AssetRootPath parameter #4775
Conversation
Reviewer's Guide by SourceryThis PR updates the static asset path handling across the application by introducing a centralized AssetRootPath parameter in WebsiteOptions. The changes replace hardcoded asset paths with a configurable path through WebsiteOption.GetAssetUrl() method. Sequence diagram for asset URL retrievalsequenceDiagram
actor User
participant Component
participant WebsiteOptions
User->>Component: Request asset
Component->>WebsiteOptions: GetAssetUrl("images/example.png")
WebsiteOptions-->>Component: "./_content/BootstrapBlazor.Shared/images/example.png"
Component-->>User: Return asset URL
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This reverts commit 139cb79.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4775 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27424 27424
Branches 3925 3925
=========================================
Hits 27424 27424 ☔ View full report in Codecov by Sentry. |
use WebsiteOption AssetRootPath parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4774
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Refactor components to use the AssetRootPath parameter from WebsiteOptions for generating asset URLs, enhancing maintainability and flexibility in asset management.
Enhancements:
Documentation: