-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(WebsiteOptions): remove WasmUrl parameter #4796
Conversation
Reviewer's Guide by SourceryThis PR removes the WasmUrl parameter from WebsiteOptions and updates related configuration files. The changes also include adding theme configurations in the development settings and cleaning up unused URL configurations in the production settings. Updated ER diagram for appsettings configurationerDiagram
WEBSITE_OPTIONS {
string ServerUrl
string AdminUrl
string ImageLibUrl
int TotalCount
}
THEMES {
string key
string name
string[] files
}
WEBSITE_OPTIONS ||--o{ THEMES : has
note for WEBSITE_OPTIONS "Removed WasmUrl attribute"
note for THEMES "Added new theme configurations"
Updated class diagram for WebsiteOptionsclassDiagram
class WebsiteOptions {
+string ServerUrl
+List~Theme~ Themes
}
class Theme {
+string key
+string name
+List~string~ files
}
WebsiteOptions --> Theme
note for WebsiteOptions "Removed WasmUrl attribute"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- PR title and description should document all URL configuration removals (WasmUrl, AdminUrl, ImageLibUrl), not just WasmUrl
- Please complete the PR template properly, including risk assessment and verification checkboxes
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4796 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27425 27425
Branches 3925 3925
=========================================
Hits 27425 27425 ☔ View full report in Codecov by Sentry. |
remove WasmUrl parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4795
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove the WasmUrl parameter from the WebsiteOptions configuration to fix issue #4795 and enhance the configuration by adding multiple theme options.
Bug Fixes:
Enhancements: