Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(WebsiteOptions): remove WasmUrl parameter #4796

Merged
merged 2 commits into from
Dec 7, 2024
Merged

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Dec 7, 2024

remove WasmUrl parameter

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4795

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Remove the WasmUrl parameter from the WebsiteOptions configuration to fix issue #4795 and enhance the configuration by adding multiple theme options.

Bug Fixes:

Enhancements:

  • Add multiple theme configurations to the WebsiteOptions, including Bootstrap, blue, Ant Design, LayUI, and DevUI themes.

Copy link

sourcery-ai bot commented Dec 7, 2024

Reviewer's Guide by Sourcery

This PR removes the WasmUrl parameter from WebsiteOptions and updates related configuration files. The changes also include adding theme configurations in the development settings and cleaning up unused URL configurations in the production settings.

Updated ER diagram for appsettings configuration

erDiagram
    WEBSITE_OPTIONS {
        string ServerUrl
        string AdminUrl
        string ImageLibUrl
        int TotalCount
    }

    THEMES {
        string key
        string name
        string[] files
    }

    WEBSITE_OPTIONS ||--o{ THEMES : has

    note for WEBSITE_OPTIONS "Removed WasmUrl attribute"
    note for THEMES "Added new theme configurations"
Loading

Updated class diagram for WebsiteOptions

classDiagram
    class WebsiteOptions {
        +string ServerUrl
        +List~Theme~ Themes
    }

    class Theme {
        +string key
        +string name
        +List~string~ files
    }

    WebsiteOptions --> Theme

    note for WebsiteOptions "Removed WasmUrl attribute"
Loading

File-Level Changes

Change Details Files
Remove WasmUrl property from WebsiteOptions class
  • Remove WasmUrl string property and its default value
src/BootstrapBlazor.Shared/Data/WebsiteOptions.cs
Update configuration files to reflect WebsiteOptions changes
  • Remove WasmUrl configuration
  • Remove other unused URL configurations (AdminUrl, ImageLibUrl)
  • Remove TotalCount configuration
  • Add theme configurations with CSS file mappings
src/BootstrapBlazor.Server/appsettings.json
src/BootstrapBlazor.Server/appsettings.Development.json

Assessment against linked issues

Issue Objective Addressed Explanation
#4795 Remove the WasmUrl parameter from WebsiteOptions

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang enabled auto-merge (squash) December 7, 2024 02:33
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • PR title and description should document all URL configuration removals (WasmUrl, AdminUrl, ImageLibUrl), not just WasmUrl
  • Please complete the PR template properly, including risk assessment and verification checkboxes
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9493604) to head (74ee050).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4796   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27425     27425           
  Branches      3925      3925           
=========================================
  Hits         27425     27425           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit caa0a52 into main Dec 7, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-select branch December 7, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc(WebsiteOptions): remove WasmUrl parameter
1 participant