Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(PrintButton): update document of PrintButton #4799

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

StevenBase
Copy link
Contributor

@StevenBase StevenBase commented Dec 7, 2024

update document of PrintButton

Summary of the changes (Less than 80 chars)

Correct DialogService to PrintService

Summary by Sourcery

Documentation:

  • Correct the reference from DialogService to PrintService in the Chinese localization file.

Summary by Sourcery

Documentation:

  • Correct the reference from DialogService to PrintService in both English and Chinese localization files.

Correct DialogService to PrintService

Signed-off-by: Silver <63774265+StevenBase@users.noreply.github.com>
Copy link

sourcery-ai bot commented Dec 7, 2024

Reviewer's Guide by Sourcery

This PR updates the documentation in the localization files to correct a reference from DialogService to PrintService. The changes are made in both English and Chinese localization files to maintain consistency in the documentation.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update service reference in localization files
  • Replace 'DialogService' with 'PrintService' in the print service documentation
  • Update both English and Chinese localizations to maintain consistency
src/BootstrapBlazor.Shared/Locales/en-US.json
src/BootstrapBlazor.Shared/Locales/zh-CN.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

bb-auto bot commented Dec 7, 2024

Thanks for your PR, @StevenBase. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang December 7, 2024 09:10
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Dec 7, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @StevenBase - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1972c70) to head (59e3e12).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4799   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27333     27333           
  Branches      3921      3921           
=========================================
  Hits         27333     27333           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ArgoZhang
ArgoZhang previously approved these changes Dec 8, 2024
@ArgoZhang ArgoZhang changed the title Update Document - PrintButton - zh-CN.json doc(PrintButton): update document of PrintButton Dec 8, 2024
@StevenBase
Copy link
Contributor Author

@microsoft-github-policy-service agree

@ArgoZhang ArgoZhang dismissed stale reviews from sourcery-ai[bot] and themself via 59e3e12 December 8, 2024 10:51
@ArgoZhang
Copy link
Collaborator

@sourcery-ai review

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @StevenBase - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@bb-auto bb-auto bot requested a review from ArgoZhang December 8, 2024 10:56
@ArgoZhang ArgoZhang merged commit 7fd4a8e into dotnetcore:main Dec 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants