Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): not trigger OnAfterCancelSaveAsync on EditForm/InCell mode #4817

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Dec 11, 2024

not trigger OnAfterCancelSaveAsync on EditForm/InCell mode

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4749

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Fix the triggering of OnAfterCancelSaveAsync in EditForm and InCell modes and add corresponding unit tests to ensure correct behavior.

Bug Fixes:

  • Fix the issue where OnAfterCancelSaveAsync was incorrectly triggered in EditForm and InCell modes.

Tests:

  • Add unit tests to verify that OnAfterCancelSaveAsync is not triggered in EditForm and InCell modes.

Copy link

sourcery-ai bot commented Dec 11, 2024

Reviewer's Guide by Sourcery

This PR fixes an issue where the OnAfterCancelSaveAsync callback wasn't being triggered in EditForm and InCell edit modes. The implementation adds the callback invocation to the CancelSave method and includes unit tests to verify the behavior.

Sequence diagram for CancelSave method with OnAfterCancelSaveAsync

sequenceDiagram
    participant User
    participant TableComponent
    participant OnAfterCancelSaveAsync

    User->>TableComponent: Trigger CancelSave
    alt EditMode is EditForm
        TableComponent->>TableComponent: Reset AddInCell and EditInCell
    end
    alt OnAfterCancelSaveAsync is not null
        TableComponent->>+OnAfterCancelSaveAsync: Invoke callback
        OnAfterCancelSaveAsync-->>-TableComponent: Callback completed
    end
Loading

File-Level Changes

Change Details Files
Added OnAfterCancelSaveAsync callback invocation to CancelSave method
  • Changed CancelSave method to be async
  • Added callback invocation after canceling save operation
  • Maintained existing edit mode cleanup logic
src/BootstrapBlazor/Components/Table/Table.razor.Toolbar.cs
Added unit tests for OnAfterCancelSaveAsync callback in different edit modes
  • Added test for EditForm mode cancel operation
  • Added test for InCell mode cancel operation
  • Verified callback is triggered after cancel button click
test/UnitTest/Components/TableTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#4749 Add ability to detect when table edit mode is cancelled

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Dec 11, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 11, 2024
@ArgoZhang ArgoZhang enabled auto-merge (squash) December 11, 2024 00:51
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dc943bb) to head (2132144).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4817   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          621       621           
  Lines        27406     27410    +4     
  Branches      3929      3930    +1     
=========================================
+ Hits         27406     27410    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 4dde0d5 into main Dec 11, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-table branch December 11, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to check if Table is in Edit Mode / OnCancelSave callback?
1 participant