-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Table): not trigger OnAfterCancelSaveAsync on EditForm/InCell mode #4817
Conversation
Reviewer's Guide by SourceryThis PR fixes an issue where the OnAfterCancelSaveAsync callback wasn't being triggered in EditForm and InCell edit modes. The implementation adds the callback invocation to the CancelSave method and includes unit tests to verify the behavior. Sequence diagram for CancelSave method with OnAfterCancelSaveAsyncsequenceDiagram
participant User
participant TableComponent
participant OnAfterCancelSaveAsync
User->>TableComponent: Trigger CancelSave
alt EditMode is EditForm
TableComponent->>TableComponent: Reset AddInCell and EditInCell
end
alt OnAfterCancelSaveAsync is not null
TableComponent->>+OnAfterCancelSaveAsync: Invoke callback
OnAfterCancelSaveAsync-->>-TableComponent: Callback completed
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4817 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 621 621
Lines 27406 27410 +4
Branches 3929 3930 +1
=========================================
+ Hits 27406 27410 +4 ☔ View full report in Codecov by Sentry. |
not trigger OnAfterCancelSaveAsync on EditForm/InCell mode
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4749
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fix the triggering of OnAfterCancelSaveAsync in EditForm and InCell modes and add corresponding unit tests to ensure correct behavior.
Bug Fixes:
Tests: