Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SelectTree): support async Items as data source #4827

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

tiansfather
Copy link
Contributor

@tiansfather tiansfather commented Dec 12, 2024

support async Items as data source

Description

fixes #{4822} (in this specific format)

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fix the issue where the initial value was not being selected in the SelectTree component by ensuring the component sets the default value when a value is assigned.

Copy link

sourcery-ai bot commented Dec 12, 2024

Reviewer's Guide by Sourcery

This PR fixes an issue with initial value selection in the SelectTree component. The implementation adds a new condition to handle cases where a Value is already assigned to the component, ensuring proper initial selection behavior.

Class diagram for SelectTree component changes

classDiagram
    class SelectTree {
        +OnParametersSetAsync() async
    }
    note for SelectTree "Added condition to handle initial value selection when Value is assigned."
Loading

File-Level Changes

Change Details Files
Added logic to handle initial value selection when the component has a pre-assigned Value
  • Added an else clause to handle the case when Value is already set
  • Implemented value-based selection using Equals comparison with the component's Value property
src/BootstrapBlazor/Components/Select/SelectTree.razor.cs

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

bb-auto bot commented Dec 12, 2024

Thanks for your PR, @tiansfather. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang December 12, 2024 05:00
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tiansfather - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please complete the PR template - mark whether this is a regression, justify the risk level, and check off the self-check items to confirm all requirements have been met.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (10ed4b3) to head (6a73c12).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4827   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          621       621           
  Lines        27405     27408    +3     
  Branches      3930      3930           
=========================================
+ Hits         27405     27408    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang changed the title feat(SelectTree)初始值选中问题 feat(SelectTree): support async Items as data source Dec 12, 2024
@ArgoZhang ArgoZhang merged commit 3ede666 into dotnetcore:main Dec 12, 2024
3 checks passed
@tiansfather tiansfather deleted the dev-tiansfather branch December 13, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants