-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SelectTree): support async Items as data source #4827
Conversation
Reviewer's Guide by SourceryThis PR fixes an issue with initial value selection in the SelectTree component. The implementation adds a new condition to handle cases where a Value is already assigned to the component, ensuring proper initial selection behavior. Class diagram for SelectTree component changesclassDiagram
class SelectTree {
+OnParametersSetAsync() async
}
note for SelectTree "Added condition to handle initial value selection when Value is assigned."
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Thanks for your PR, @tiansfather. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tiansfather - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template - mark whether this is a regression, justify the risk level, and check off the self-check items to confirm all requirements have been met.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4827 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 621 621
Lines 27405 27408 +3
Branches 3930 3930
=========================================
+ Hits 27405 27408 +3 ☔ View full report in Codecov by Sentry. |
support async Items as data source
Description
fixes #{4822} (in this specific format)
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: