Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SelectGeneric): add SelectGeneric component #4838

Merged
merged 18 commits into from
Dec 13, 2024
Merged

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Dec 13, 2024

add SelectGeneric component

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4837

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add the SelectGeneric component to provide a flexible and generic select input solution, refactor existing select components to use this new component, and enhance test coverage to ensure reliability.

New Features:

  • Introduce the SelectGeneric component, a new generic select component that supports various data types and provides enhanced functionality such as virtual scrolling, search, and customizable templates.

Enhancements:

  • Refactor existing select components to utilize the new SelectGeneric component, improving code maintainability and flexibility.

Tests:

  • Add unit tests for the SelectGeneric component to ensure its functionality, including tests for search, selection, and virtual scrolling features.

Copy link

sourcery-ai bot commented Dec 13, 2024

Reviewer's Guide by Sourcery

This PR introduces a new generic select component SelectGeneric that replaces the existing Select component. The implementation focuses on improving type safety and component architecture by using strongly typed generic parameters throughout the component hierarchy.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Introduced new generic select component with improved type safety
  • Created SelectGeneric component that inherits from SelectBase
  • Added strongly typed SelectedItem class to replace the non-generic version
  • Implemented ISelectGeneric interface for component contracts
  • Added SelectOptionGeneric component for type-safe select options
src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor
src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor.cs
src/BootstrapBlazor/Components/SelectGeneric/ISelectGeneric.cs
src/BootstrapBlazor/Components/SelectGeneric/SelectOptionGeneric.cs
Updated test suite to use new generic components
  • Refactored existing tests to use SelectGeneric instead of Select
  • Added new test cases for generic type handling
  • Updated test assertions to match new component behavior
test/UnitTest/Components/SelectTest.cs
Modified supporting infrastructure for generic components
  • Updated EnumExtensions to support generic type conversion
  • Modified SelectedItem class hierarchy to support generic values
  • Added new SCSS styles for SelectGeneric component
src/BootstrapBlazor/Extensions/EnumExtensions.cs
src/BootstrapBlazor/Misc/SelectedItemOfT.cs
src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#4837 Add SelectGeneric component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Dec 13, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 13, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider extracting shared logic between Select and SelectGeneric into helper methods or a base class to reduce code duplication
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 99.73046% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.99%. Comparing base (a21ae6a) to head (0fd25da).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lazor/Components/SelectGeneric/SelectGeneric.razor 98.63% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #4838      +/-   ##
===========================================
- Coverage   100.00%   99.99%   -0.01%     
===========================================
  Files          621      620       -1     
  Lines        27409    27402       -7     
  Branches      3930     3925       -5     
===========================================
- Hits         27409    27401       -8     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit a46e51d into main Dec 13, 2024
4 of 5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-selected branch December 13, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(SelectGeneric): add SelectGeneric component
1 participant