-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Select): auto load data on virtual mode #4852
Conversation
Reviewer's Guide by SourceryThis PR implements auto-loading of data in virtual mode for Select components. The changes introduce a new RefreshVirtualizeElement method and add OnAfterRenderAsync lifecycle hook to automatically load data on first render. The implementation is consistent across both Select and SelectGeneric components. Sequence diagram for auto-loading data in virtual modesequenceDiagram
actor User
participant SelectComponent
participant VirtualizeElement
User->>SelectComponent: Render component
SelectComponent->>SelectComponent: OnAfterRenderAsync(firstRender)
alt firstRender is true
SelectComponent->>SelectComponent: RefreshVirtualizeElement()
SelectComponent->>VirtualizeElement: RefreshDataAsync()
VirtualizeElement-->>SelectComponent: Data loaded
SelectComponent->>SelectComponent: StateHasChanged()
end
Updated class diagram for Select componentclassDiagram
class Select {
+Task OnAfterRenderAsync(bool firstRender)
+Task RefreshVirtualizeElement()
-Task SearchTextChanged(string val)
-bool IsVirtualize
-Func OnQueryAsync
-VirtualizeElement VirtualizeElement
}
class SelectGeneric {
+Task OnAfterRenderAsync(bool firstRender)
+Task RefreshVirtualizeElement()
-Task SearchTextChanged(string val)
-bool IsVirtualize
-Func OnQueryAsync
-VirtualizeElement VirtualizeElement
}
Select <|-- SelectGeneric
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template with proper documentation - including risk assessment, verification details, and a clear description of the behavior changes (particularly around the test modification).
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4852 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 623 623
Lines 27809 27831 +22
Branches 3980 3982 +2
=========================================
+ Hits 27809 27831 +22 ☔ View full report in Codecov by Sentry. |
auto load data on virtual mode
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4851
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Refactor the Select component to automatically load data when in virtual mode by introducing a new method to refresh the virtualized element. Update the unit test to ensure the correct value binding in virtual mode.
Enhancements:
Tests: