-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(SearchBox): add SearchableColumns parameter #4875
Conversation
Reviewer's Guide by SourceryThe PR adds a SearchableColumns parameter to the MeiliSearchBox component in GlobalSearch.razor, configuring specific columns that can be searched. The implementation defines a list of searchable columns including menu, title, subTitle, and demos-related fields. Class diagram for GlobalSearch component updateclassDiagram
class GlobalSearch {
- IStringLocalizer<GlobalSearch> Localizer
+ List~string~ SearchableColumns
}
class MeiliSearchBox {
+ string SearchBoxPlaceHolder
+ string SearchStatus
+ string SearchResultPlaceHolder
+ List~string~ SearchableColumns
}
GlobalSearch --> MeiliSearchBox: uses
note for GlobalSearch "SearchableColumns parameter added to specify searchable fields"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template, particularly the Risk assessment and Verification sections, to help reviewers better understand the impact of these changes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4875 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 623 623
Lines 27832 27832
Branches 3982 3982
=========================================
Hits 27832 27832 ☔ View full report in Codecov by Sentry. |
add SearchableColumns parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4874
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: