-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SelectTable): support auto fill when collapse search panel #4881
Conversation
Reviewer's Guide by SourceryThis PR improves the table component's height calculation and resize handling by restructuring the initialization flow and observer setup. The changes optimize the handling of table visibility and height calculations, particularly when the search panel is collapsed. Sequence diagram for table height calculation and resize handlingsequenceDiagram
participant User
participant TableComponent
participant ResizeObserver
participant AnimationFrame
User->>TableComponent: Collapse search panel
TableComponent->>TableComponent: Check visibility
alt Table is not visible
TableComponent->>AnimationFrame: Request animation frame for height check
else Table is visible
TableComponent->>ResizeObserver: Observe height changes
ResizeObserver->>TableComponent: Notify on resize
TableComponent->>TableComponent: Set table default width
end
AnimationFrame->>TableComponent: Notify on animation frame
TableComponent->>TableComponent: Check height again
alt Table is visible
TableComponent->>ResizeObserver: Observe height changes
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4881 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 623 623
Lines 27832 27832
Branches 3982 3982
=========================================
Hits 27832 27832 ☔ View full report in Codecov by Sentry. |
support auto fill when collapse search panel
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4880
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add auto-fill support for the SelectTable component when the search panel is collapsed and enhance height management with a new observeHeight function.
New Features:
Enhancements: