Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SelectTable): support auto fill when collapse search panel #4881

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Dec 18, 2024

support auto fill when collapse search panel

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4880

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add auto-fill support for the SelectTable component when the search panel is collapsed and enhance height management with a new observeHeight function.

New Features:

  • Add support for auto-filling when the search panel is collapsed in the SelectTable component.

Enhancements:

  • Improve height observation and management in the table component by introducing a new observeHeight function.

@bb-auto bb-auto bot added the enhancement New feature or request label Dec 18, 2024
Copy link

sourcery-ai bot commented Dec 18, 2024

Reviewer's Guide by Sourcery

This PR improves the table component's height calculation and resize handling by restructuring the initialization flow and observer setup. The changes optimize the handling of table visibility and height calculations, particularly when the search panel is collapsed.

Sequence diagram for table height calculation and resize handling

sequenceDiagram
    participant User
    participant TableComponent
    participant ResizeObserver
    participant AnimationFrame

    User->>TableComponent: Collapse search panel
    TableComponent->>TableComponent: Check visibility
    alt Table is not visible
        TableComponent->>AnimationFrame: Request animation frame for height check
    else Table is visible
        TableComponent->>ResizeObserver: Observe height changes
        ResizeObserver->>TableComponent: Notify on resize
        TableComponent->>TableComponent: Set table default width
    end
    AnimationFrame->>TableComponent: Notify on animation frame
    TableComponent->>TableComponent: Check height again
    alt Table is visible
        TableComponent->>ResizeObserver: Observe height changes
    end
Loading

File-Level Changes

Change Details Files
Restructured table initialization and height calculation logic
  • Added table.shim property to store shim element reference
  • Moved visibility check to earlier in the initialization process
  • Extracted height observation logic into separate function
  • Updated ResizeObserver to use stored shim reference
src/BootstrapBlazor/Components/Table/Table.razor.js
Improved animation frame handling for height calculations
  • Added proper cleanup of animation frame handler
  • Moved visibility check logic to initialization phase
  • Added condition to prevent multiple animation frame handlers
src/BootstrapBlazor/Components/Table/Table.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#4880 Support auto fill when collapse search panel in SelectTable component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 18, 2024
@ArgoZhang ArgoZhang enabled auto-merge (squash) December 18, 2024 06:55
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (52d30ad) to head (4cb0b10).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4881   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          623       623           
  Lines        27832     27832           
  Branches      3982      3982           
=========================================
  Hits         27832     27832           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit e332b14 into main Dec 18, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-table branch December 18, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(SelectTable): support auto fill when collapse search panel
1 participant