-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GotoTop): support IsFixedTabHeader layout component #4883
Conversation
Reviewer's Guide by SourceryThis PR implements support for IsFixedTabHeader layout component by modifying the GoTop component to work with fixed tab headers. The implementation moves the target element logic to the Layout component and passes it to GoTop through a data attribute, removing the need for JavaScript initialization. Class diagram for Layout and GoTop componentsclassDiagram
class Layout {
- bool _init
+ string? GetTargetString()
}
class GoTop {
- Task InvokeInitAsync()
}
Layout --> GoTop : uses
note for Layout "GetTargetString method added to determine target element based on IsFixedTabHeader"
note for GoTop "InvokeInitAsync method removed, target logic moved to Layout"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template with details about risk assessment and verification steps. This helps reviewers understand the impact and testing done.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj Co-authored-by: yuchen7701 <844356115@qq.com> Co-authored-by: 卢骥 <1429614920@qq.com> Co-authored-by: Argo Zhang <argo@live.ca>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4883 +/- ##
===========================================
- Coverage 100.00% 99.99% -0.01%
===========================================
Files 623 623
Lines 27832 27832
Branches 3982 3983 +1
===========================================
- Hits 27832 27831 -1
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
support IsFixedTabHeader layout component
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4882
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add support for the IsFixedTabHeader layout component in the GoTop feature and refactor the GoTop component to use a data-bb-target attribute for specifying the scroll target.
New Features:
Enhancements: