-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TableColumn): remove Formatter on TableColumn #4892
Conversation
Reviewer's Guide by SourceryThis PR removes the Formatter functionality from TableColumn component and replaces it with FormatString where needed. The implementation focuses on simplifying the column value rendering logic by eliminating the async formatter callback delegate and relying on the FormatString property instead. Sequence diagram for TableColumn rendering processsequenceDiagram
participant User
participant TableColumn
participant Utility
User->>TableColumn: Request to render value
TableColumn->>Utility: Format value using FormatString
Utility-->>TableColumn: Formatted value
TableColumn-->>User: Rendered value
note over TableColumn: Formatter callback removed
Class diagram for TableColumn changesclassDiagram
class TableColumn {
- Formatter
+ FormatString
}
class TableColumnContext {
- Value
}
TableColumn --> TableColumnContext : uses
note for TableColumn "Formatter removed, FormatString used instead"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please update the documentation to reflect the removal of the Formatter property from TableColumn, as this is a breaking change that affects the public API.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@codecov-ai-reviewer review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4892 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 623 624 +1
Lines 27846 27863 +17
Branches 3993 4002 +9
=========================================
+ Hits 27846 27863 +17 ☔ View full report in Codecov by Sentry. |
remove Formatter on TableColumn
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4887
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: