-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TreeView): reset Items to null #4894
Conversation
Reviewer's Guide by SourceryThis PR fixes a TreeView refresh issue by adjusting when node recalculation occurs. The main change moves the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Thanks for your PR, @kimdiego2098. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kimdiego2098 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template, especially the regression status and risk assessment sections.
- Consider adding a code comment explaining why _rows needs to be reset regardless of IsReset value.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kimdiego2098 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template with risk assessment, verification details, and other required information to help with review and maintenance.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4894 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 623 624 +1
Lines 27846 27872 +26
Branches 3993 4003 +10
=========================================
+ Hits 27846 27872 +26 ☔ View full report in Codecov by Sentry. |
修复 IsReset 为false时,Items变化后无法正常刷新 的问题
Summary of the changes (Less than 80 chars)
修复 IsReset 为false时,Items变化后无法正常刷新 的问题
Description
fixes #4895
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: