Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TreeView): reset Items to null #4894

Merged
merged 6 commits into from
Dec 19, 2024
Merged

fix(TreeView): reset Items to null #4894

merged 6 commits into from
Dec 19, 2024

Conversation

kimdiego2098
Copy link
Collaborator

@kimdiego2098 kimdiego2098 commented Dec 19, 2024

修复 IsReset 为false时,Items变化后无法正常刷新 的问题

Summary of the changes (Less than 80 chars)

修复 IsReset 为false时,Items变化后无法正常刷新 的问题

Description

fixes #4895

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fix issue where TreeView does not refresh correctly when IsReset is false and Items change.

Copy link

sourcery-ai bot commented Dec 19, 2024

Reviewer's Guide by Sourcery

This PR fixes a TreeView refresh issue by adjusting when node recalculation occurs. The main change moves the _rows = null reset operation outside the IsReset condition, ensuring nodes are properly recalculated whenever Items change, regardless of the IsReset flag value.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Restructured node recalculation logic in TreeView component
  • Moved _rows nullification outside of IsReset condition block
  • Ensures node recalculation happens for all Items changes
  • Added comment indicating node recalculation purpose
src/BootstrapBlazor/Components/TreeView/TreeView.razor.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

bb-auto bot commented Dec 19, 2024

Thanks for your PR, @kimdiego2098. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang December 19, 2024 08:34
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kimdiego2098 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please complete the PR template, especially the regression status and risk assessment sections.
  • Consider adding a code comment explaining why _rows needs to be reset regardless of IsReset value.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Dec 19, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kimdiego2098 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please complete the PR template with risk assessment, verification details, and other required information to help with review and maintenance.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7de5f7e) to head (80e504b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4894   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          623       624    +1     
  Lines        27846     27872   +26     
  Branches      3993      4003   +10     
=========================================
+ Hits         27846     27872   +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang changed the title fix(TreeView): 修复 IsReset 为false时,Items变化后无法正常刷新 的问题 fix(TreeView): reset Items to null Dec 19, 2024
@bb-auto bb-auto bot added the bug Something isn't working label Dec 19, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 19, 2024
ArgoZhang
ArgoZhang previously approved these changes Dec 19, 2024
@ArgoZhang ArgoZhang merged commit c4901f2 into main Dec 19, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the treeview_dev branch December 19, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(TreeView): reset Items to null not work
2 participants