-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Select): add LookupService parameter #4898
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new Sequence diagram for Select component data loading with LookupServicesequenceDiagram
participant Select as Select Component
participant LS as LookupService
Note over Select: OnParametersSetAsync
alt LookupService is provided
Select->>LS: GetItemsByKeyAsync(LookupServiceKey, LookupServiceData)
LS-->>Select: Returns SelectedItems[]
else No LookupService
Note over Select: Returns empty array
end
Note over Select: Update Items collection
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The loading spinner markup is still present but its visibility control was removed. This could cause the spinner to be permanently visible - consider either implementing proper visibility control or removing the spinner markup entirely.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4898 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 624 624
Lines 27872 27870 -2
Branches 4003 4001 -2
=========================================
- Hits 27872 27870 -2 ☔ View full report in Codecov by Sentry. |
add LookupService parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4897
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a
LookupService
parameter to theSelect
component to allow it to fetch data from a lookup service.New Features:
Select
component to use a lookup service to populate its options.Tests: