feat(Display): support LookupService method GetItemsByKeyAsync #4924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: chengKun <49547008+zhaijunlei955@users.noreply.github.com>
更新 Lookup 逻辑 Co-Authored-By: chengKun <49547008+zhaijunlei955@users.noreply.github.com>
Reviewer's Guide by SourceryThis pull request introduces support for asynchronous lookups in the Sequence diagram for Display component async lookup flowsequenceDiagram
participant Display as Display Component
participant LS as LookupService
Display->>Display: OnParametersSetAsync
Display->>Display: FormatDisplayText
Display->>Display: FormatText
alt Has Lookup Key
Display->>Display: GetLookup
Display->>LS: GetItemsAsync(key, data)
LS-->>Display: Return lookup items
Display->>Display: Format with lookup data
else No Lookup Key
Display->>Display: Direct format
end
Display->>Display: Update display text
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4924 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 628 628
Lines 28073 28082 +9
Branches 4038 4042 +4
=========================================
+ Hits 28073 28082 +9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support LookupService method GetItemsByKeyAsync
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号
Description
fixes #4923
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add support for the
GetItemsByKeyAsyncmethod in theLookupServicefor theDisplaycomponent.New Features:
Displaycomponent now supports asynchronous lookup of items using theGetItemsByKeyAsyncmethod from theLookupService.Tests: