-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Table): render tooltip support LookupService GetItemByKeyAsync #4926
Conversation
Co-Authored-By: ZhYan <19183404+Axxbis@users.noreply.github.com>
Co-Authored-By: ZhYan <19183404+Axxbis@users.noreply.github.com>
Co-Authored-By: ZhYan <19183404+Axxbis@users.noreply.github.com>
Reviewer's Guide by SourceryThis pull request implements tooltip support for the LookupService GetItemByKeyAsync method in the Table component. It introduces a new MockLookupServiceAsync class for testing and updates the Table component to use the LookupService to retrieve tooltip text asynchronously. It also modifies the ITableColumn interface to include a LookupService property and updates the TableFilter component to use the IsLookup method. Sequence diagram for Table tooltip rendering with LookupServicesequenceDiagram
participant Table
participant TableColumn
participant LookupService
participant Tooltip
Table->>TableColumn: RenderValue(item, lookupService)
alt IsLookup() && value != null
TableColumn->>TableColumn: RenderTooltip(value, item, lookupService)
alt Has GetTitleCallback
TableColumn->>LookupService: GetItemsAsync(key, data)
LookupService-->>TableColumn: lookup items
TableColumn->>TableColumn: Find matching lookup value
TableColumn->>Tooltip: Set GetTitleCallback
end
end
Class diagram for Table and LookupService integrationclassDiagram
class ITableColumn {
+Lookup: IEnumerable~LookupItem~
+LookupService: ILookupService
+LookupServiceKey: string
+LookupServiceData: object
+LookupStringComparison: StringComparison
+IsLookup() bool
+RenderValue(item, lookupService) RenderFragment
+RenderTooltip(text, item, lookupService) RenderFragment
}
class ILookupService {
+GetItemsAsync(key, data) Task~IEnumerable~LookupItem~~
}
class Table {
+LookupService: ILookupService
+GetValue(col, item) RenderFragment
}
Table --> ITableColumn
Table --> ILookupService
ITableColumn --> ILookupService
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4926 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 628 628
Lines 28082 28078 -4
Branches 4042 4041 -1
=========================================
- Hits 28082 28078 -4 ☔ View full report in Codecov by Sentry. |
render tooltip support LookupService GetItemByKeyAsync
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4925
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: