Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): support Items from LookupService #4928

Merged
merged 6 commits into from
Dec 23, 2024
Merged

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Dec 23, 2024

support Items from LookupService

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4927

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

New Features:

  • Added the ability to use a LookupService to populate the items of a Select component.

ArgoZhang and others added 5 commits December 23, 2024 14:02
Co-Authored-By: Diego2098 <82756760+kimdiego2098@users.noreply.github.com>
Co-Authored-By: Diego2098 <82756760+kimdiego2098@users.noreply.github.com>
Copy link

sourcery-ai bot commented Dec 23, 2024

Reviewer's Guide by Sourcery

This pull request implements support for fetching items from a LookupService in the Select component. It introduces a new LookupServiceKey property to specify the lookup key and injects an ILookupService instance to retrieve the items. The changes also include updates to the GetItemsAsync method to use the LookupService and unit tests to verify the functionality.

Sequence diagram for Select component item retrieval with LookupService

sequenceDiagram
    participant Select as Select Component
    participant LS as LookupService
    Note over Select: GetItemsAsync called
    alt LookupServiceKey is not empty
        Select->>LS: GetItemsAsync(LookupServiceKey, LookupServiceData)
        LS-->>Select: Return items
    else LookupServiceKey is empty
        Note over Select: Return empty array
    end
Loading

File-Level Changes

Change Details Files
Added LookupService support to the Select component.
  • Injected ILookupService instance.
  • Added LookupServiceKey property.
  • Modified GetItemsAsync to fetch items from LookupService if LookupServiceKey is provided.
  • Added a GetLookupService method to resolve the correct lookup service instance.
  • Updated OnAfterRenderAsync to use the new GetItemsAsync method.
src/BootstrapBlazor/Components/Select/Select.razor.cs
Added unit tests for LookupService functionality.
  • Added a test case to SelectTest to verify item retrieval from LookupService.
  • Added test cases to EditorFormTest to verify LookupService integration with EditorForm.
test/UnitTest/Components/SelectTest.cs
test/UnitTest/Components/EditorFormTest.cs
No changes related to packaging. src/BootstrapBlazor/BootstrapBlazor.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#4927 Add support for Items from LookupService in the Select component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Dec 23, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 23, 2024
@ArgoZhang ArgoZhang enabled auto-merge (squash) December 23, 2024 06:12
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Dec 23, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please complete the PR description template, particularly the risk assessment justification and verification details. This helps reviewers better understand the impact of the changes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

test/UnitTest/Components/SelectTest.cs Show resolved Hide resolved
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8de9a2e) to head (07cc570).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4928   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          628       628           
  Lines        28082     28080    -2     
  Branches      4042      4042           
=========================================
- Hits         28082     28080    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang disabled auto-merge December 23, 2024 06:22
@ArgoZhang ArgoZhang merged commit 5ca7516 into main Dec 23, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-select branch December 23, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Select): support Items from LookupService
1 participant