-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Select): support Items from LookupService #4928
Conversation
Co-Authored-By: Diego2098 <82756760+kimdiego2098@users.noreply.github.com>
Co-Authored-By: Diego2098 <82756760+kimdiego2098@users.noreply.github.com>
Reviewer's Guide by SourceryThis pull request implements support for fetching items from a LookupService in the Select component. It introduces a new LookupServiceKey property to specify the lookup key and injects an ILookupService instance to retrieve the items. The changes also include updates to the GetItemsAsync method to use the LookupService and unit tests to verify the functionality. Sequence diagram for Select component item retrieval with LookupServicesequenceDiagram
participant Select as Select Component
participant LS as LookupService
Note over Select: GetItemsAsync called
alt LookupServiceKey is not empty
Select->>LS: GetItemsAsync(LookupServiceKey, LookupServiceData)
LS-->>Select: Return items
else LookupServiceKey is empty
Note over Select: Return empty array
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR description template, particularly the risk assessment justification and verification details. This helps reviewers better understand the impact of the changes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4928 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 628 628
Lines 28082 28080 -2
Branches 4042 4042
=========================================
- Hits 28082 28080 -2 ☔ View full report in Codecov by Sentry. |
support Items from LookupService
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4927
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: