Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Row): support custom class attribute #5113

Merged
merged 2 commits into from
Jan 15, 2025
Merged

feat(Row): support custom class attribute #5113

merged 2 commits into from
Jan 15, 2025

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Jan 15, 2025

support custom class attribute

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5111

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add support for custom class attribute to the Row component.

New Features:

  • Allow setting custom classes on the Row component using AdditionalAttributes.

Tests:

  • Added unit tests to verify the functionality of custom classes.

@bb-auto bb-auto bot added the enhancement New feature or request label Jan 15, 2025
@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 15, 2025
Copy link

sourcery-ai bot commented Jan 15, 2025

Reviewer's Guide by Sourcery

This pull request introduces the ability to add custom class attributes to the Row component.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added support for custom class attribute
  • Added ClassString property to compute the final CSS class string based on the AdditionalAttributes.
  • Applied the ClassString property to the div element in the Row component.
  • Added unit tests to verify the functionality of the custom class attribute and ensure that the d-none class is always present if no custom class is provided or if the custom class is empty.
  • Updated the Row component to use the new ClassString property to render the class attribute.
  • Added unit tests to verify the ClassString property and its interaction with the AdditionalAttributes parameter.
  • Added a test case to verify that the d-none class is always present even when custom classes are provided via AdditionalAttributes.
  • Added a test case to verify that custom classes are correctly applied to the Row component via AdditionalAttributes.
  • Added a test case to verify that the ClassString property correctly handles null or empty AdditionalAttributes.
  • Added a test case to verify that the ClassString property correctly merges the d-none class with custom classes provided via AdditionalAttributes.
  • Added a test case to verify that the ClassString property correctly handles multiple custom classes provided via AdditionalAttributes.
src/BootstrapBlazor/Components/Row/Row.razor.cs
src/BootstrapBlazor/Components/Row/Row.razor
test/UnitTest/Components/RowTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5111 Make class attribute work like other components

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang enabled auto-merge (squash) January 15, 2025 09:19
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The hardcoded 'd-none' class makes rows hidden by default - is this intentional? Consider removing this default or document why it's necessary.
  • Please complete the PR description template in English to improve collaboration.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

test/UnitTest/Components/RowTest.cs Show resolved Hide resolved
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (96c3db5) to head (baf4a67).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5113   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          634       634           
  Lines        28171     28174    +3     
  Branches      4041      4041           
=========================================
+ Hits         28171     28174    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 42852a6 into main Jan 15, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-row branch January 15, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Row): class attribute has no effect on this component.
1 participant