-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Modal): add back/restoreBodyStyle function #5544
Conversation
# Conflicts: # src/BootstrapBlazor/Components/Modal/Modal.razor.js
Reviewer's Guide by SourceryThis pull request refactors the Sequence diagram for hiding the modalsequenceDiagram
participant document
participant modal
document->>modal: modal.hide()
activate modal
modal->>modal: modal.modal.hide()
modal->>modal: restoreBodyStyle(modal)
alt modal.originalStyle is defined
modal->>document: document.body.style.cssText = modal.originalStyle
modal->>modal: delete modal.originalStyle
end
modal->>modal: invoke.invokeMethodAsync(modal.closeCallback)
deactivate modal
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding comments to the helper functions to explain their purpose.
- It might be clearer to use
modal.originalStyle === undefined
instead ofmodal.originalStyle ??= ...
andmodal.originalStyle !== undefined
instead ofmodal.originalStyle
.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5544 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29607 29607
Branches 4173 4173
=========================================
Hits 29607 29607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5543
[Please fill in the relevant Issue number after the # above, such as #42]
[请在上方 # 后面填写相关 Issue 编号,如 #42]
Summary By Copilot
This pull request includes refactoring of the
Modal
component insrc/BootstrapBlazor/Components/Modal/Modal.razor.js
to improve the handling of the document body style when showing and hiding modals. The most important changes include the introduction of helper functions to backup and restore the body style.Refactoring of modal body style handling:
src/BootstrapBlazor/Components/Modal/Modal.razor.js
: Replaced inline style backup and restore logic withbackupBodyStyle
andrestoreBodyStyle
helper functions inmodal.show
,modal.hide
, anddispose
functions. [1] [2] [3]backupBodyStyle
function to store the original body style inmodal.originalStyle
if it is not already set.restoreBodyStyle
function to revert the body style to the original and deletemodal.originalStyle
if it is set.Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: