Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With these changes a consumer of the DotNetCore.CAP.NATS nuget package can opt out from allowing a NATS Consumer client to create topics and streams dynamically which enforces each client to be granted "admin" like permissions. To avoid assigning these permissions to each client, a consumer of the nuget package can now opt out from this by specifying NATSOptions property
EnableSubscriberClientStreamAndSubjectCreation
tofalse
(defaults to true).Issue(s) addressed:
Changes:
NATSOptions
propertyEnableSubscriberClientStreamAndSubjectCreation
and usage of it inNatsConsumerClient.FetchTopics
method.OnLogCallback
withMqLogType.ConnectError
in order to mark theConsumerRegister
as "unhealthy" to allow "subscribe retries" calls to theNatsConsumerClinet.Subscribe
method in case the server have not yet configured the expected stream before the client tries to subscribe.Affected components:
DotNetCore.CAP.NATS
How to test:
Configured with NatsOptions
EnableSubscriberClientStreamAndSubjectCreation: false
Checklist:
Reviewers: