Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle existing cap-msg-group header and tolerate duplicate headers for Kafka consumer #1623

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

PoteRii
Copy link
Contributor

@PoteRii PoteRii commented Dec 5, 2024

Description:

Handle existing cap-msg-group header (by overwriting it) and tolerate duplicate headers for Kafka consumer (since testers tend to do stuff manually sometimes and mess up with message headers as well)

Issue(s) addressed:

How to test:

Produce a message to Kafka or any other supported system with cap-msg-group header

Checklist:

  • [ ✓] I have tested my changes locally
  • I have added necessary documentation (if applicable)
  • I have updated the relevant tests (if applicable)
  • [ ✓] My changes follow the project's code style guidelines

…rwrite it instead. tolerate kafka message duplicate headers
Copy link
Member

@yang-xiaodong yang-xiaodong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , Thanks

@yang-xiaodong yang-xiaodong merged commit 09f2a05 into dotnetcore:master Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants