Bug Fix in Parsing of FB and Datablocks and Proper S7Attribute Parsing #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues present. Added BlockAttributes and BlockVersion to the S7Block. I encountered an problem when parsing the Block Version. With my testing data, the blocks have always been Version 1 (0.1) even though they should have had a different version. This was al ready like this in the raw MC7 code on Byte 2. So either the BLock version is stored at an differnet offset, or something else is going wrong.
|
Just for information. The bit 0 in the attributes is true if the block is linked and false if not (made some tests). This is actually different from what the simatic manager shows. The simatic manager essentially shows this status reversed, it has an unlinked attribute instead an linked attribute. |
jogibear9988
approved these changes
Jul 28, 2017
|
Thanks again!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix when parsing the FB or DB Interface, the the Actual values where not available
Added BlockAttributes and BlockVersion to the S7Block.
I encountered an problem when parsing the Block Version. With my testing data, the blocks have always been Version 1 (0.1) even though they should have had a different version. This was al ready like this in the raw MC7 code on Byte 2. So either the BLock version is stored at an different offset, or something else is going wrong.