Bug fixes in Block Interface Parsing #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 20, 2017 23:58
… now correctly parsed from interfaces
-Eliminated possible Endless Loop -Added support for MultiInstance Block Declarations
|
Sorry for the followup Pull Request, i didnt expect to have time to go into it |
|
thx again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unexpectedly i had some time to go into the bugs that i mentioned in #83, and it was easier than i Thought
I fixed the following issues:
-The Code could enter an Endless loop, when the interface contained unexpected values. This now correctly throws an exception
-I also added Support for Multi Instance FBxx and SFBxx declarations, which are actually a special case in the MC7 format.