Update of MLX-LM generate_step to support repetition_penalty #1134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix #1131, here is an updated
mlxlm.py
with support ofrepetition_penalty
andrepetition_context_size
parameters ingenerate_step
function.It prevents the LLM model to fall into an infinite loop of generating the same group of tokens endlessly.
These parameters
repetition_penalty
andrepetition_context_size
can therefore be directly passed as arguments to thegenerator
. Here is an example: