forked from typelevel/scalacheck
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid ambiguous implicit errors with dotty
For a Boolean b and a prop p, the following is ambiguous in dotty: b ==> p Because we have: implicit def BooleanOperators(b: => Boolean) = new ExtendedBoolean(b) implicit def propBoolean(b: Boolean): Prop = Prop(b) And both ExtendedBoolean and Prop provide a `==>` method, the one in `ExtendedBoolean` just forwards to the one in `Prop`. This is not ambiguous in scalac because `Boolean` wins against `=> Boolean` but it is in dotty. This commit fixes this by removing the `==>` method from `ExtendedBoolean`, this may break code that explicitly imported `BooleanOperators` but not `propBoolean`, the fix is to also import `propBoolean`.
- Loading branch information
1 parent
0a98a51
commit 00f01af
Showing
8 changed files
with
7 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters