fix(web): removed dynamic shaka-player import

[Bram-dc]

Let bundlers decide how to import the package instead of forcing a dynamic import.

[Bram-dc]

I now finally understand the issue. Not sure how to solve it :(

[jspizziri]

@Bram-dc , can you describe the issue you're having with the dynamic import?

[Bram-dc]

Yeah, I will create a sample project!

[Bram-dc]

@jspizziri https://github.com/Bram-dc/rntp-web-demo

shaka-player will be undefined.

It is an easy fix by forcing the bundler to transform the shaka file again. See the commented lines in vite.config.mts. I was about to close this PR, because of that. It would be nice however if we would not need to do this extra step.

[Bram-dc]

I also think this has become an issue because shaka-player is distributed for these modern javascript projects and not a "bug" in RNTP. By importing the file directly bundlers will almost in every case do this extra step automatically. The dynamic import will break the code in specific bundlers. In my projects I use vite as bundler and it has an easy fix for this problem. Maybe other bundlers do not have this options. This problem affects only a very small group of people (react-native-web + rntp + modules), and not worth patching in this library. (shaka-player is the issue because it is not made for these environments).

[jspizziri]

@Bram-dc this is interesting... it seems like Vite is doing something wrong. Dynamic imports are part of the JS spec so I'm not sure why it's not doing it properly. Do you have any insights there? (never used vite and I'm old enough to have bundler fatigue at this point haha).

When I ran your project, I did notice that something from shaka was importing (specifically shaka.default existed), but I'm not sure why things are breaking. I'll have to take a bit more time digging into it. But generally speaking, something doesn't smell right to me at the moment.

[jspizziri]

@Bram-dc please take a look at this PR

#2299

[jspizziri]

I'm going to close this PR in favor of the one I just opened. In short, I don't think dynamic imports in and of themselves are the issue here.