Fixes to sqlite dialect: do not add FOR UPDATE in SELECT, fix support for INSERT ON CONFLICT #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlanse
commented
May 15, 2020
| @@ -121,6 +121,7 @@ if err != nil{ | |||
| Output: | |||
| ``` | |||
| SELECT * FROM "test" WHERE "id" = 10 [] | |||
| ``` | |||
There was a problem hiding this comment.
leftover from my previous PR with sqlserver support :)
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
=======================================
Coverage 96.51% 96.51%
=======================================
Files 60 60
Lines 4189 4195 +6
=======================================
+ Hits 4043 4049 +6
Misses 131 131
Partials 15 15
Continue to review full report at Codecov.
|
vlanse
commented
May 19, 2020
| ) | ||
|
|
||
| func init() { | ||
| RegisterDialect("default", DefaultDialectOptions()) | ||
| } | ||
|
|
||
| func RegisterDialect(name string, do *SQLDialectOptions) { | ||
| dialectsMu.Lock() |
There was a problem hiding this comment.
similar to this: https://github.com/golang/go/blob/master/src/database/sql/sql.go#L45
faced problem with concurrent map writes in our test environment
vlanse
changed the title
|
@doug-martin could you please proceed with review? |
doug-martin
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite lacks support of SELECT FOR UPDATE: https://sqlite.org/lang_select.html
To enable cross-database queries building with that syntax and avoid additional conditions in application code, need to insert empty fragment for SQLite dialect