Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SELECT inherits dialect from INSERT in INSERT FROM SELECT construct, fixes #223 #229

Merged
merged 1 commit into from
Sep 17, 2020
Merged

SELECT inherits dialect from INSERT in INSERT FROM SELECT construct, fixes #223 #229

merged 1 commit into from
Sep 17, 2020

Conversation

vlanse
Copy link
Contributor

@vlanse vlanse commented Aug 29, 2020

No description provided.

@codecov
Copy link

codecov bot commented Aug 29, 2020 •
edited
Loading

Codecov Report

Merging #229 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   96.51%   96.52%   +0.01%     
==========================================
  Files          60       60              
  Lines        4189     4204      +15     
==========================================
+ Hits         4043     4058      +15     
  Misses        131      131              
  Partials       15       15
Impacted Files Coverage Δ
insert_dataset.go 100.00% <100.00%> (ø)
sql_dialect.go 100.00% <0.00%> (ø)
dialect/sqlite3/sqlite3.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 417f438...fb9c5f8. Read the comment docs.

@doug-martin doug-martin merged commit 2f77fbe into doug-martin:master Sep 17, 2020
doug-martin added a commit that referenced this pull request Sep 17, 2020
@doug-martin
v9.10.0
bea1557 
* [FIXED] SELECT inherits dialect from INSERT in INSERT FROM SELECT.  #229, #223 - @vlanse
* [FIXED] SQLServer dialect: support prepared statements with TOP.  #230, #225 - @vlanse
* [ADDED] IsPrepared to SQLExpression interface.  #231 - @vlanse
@doug-martin doug-martin mentioned this pull request Sep 17, 2020
Merged
doug-martin added a commit that referenced this pull request Sep 17, 2020
@doug-martin
v9.10.0
865b53c 
* [FIXED] SELECT inherits dialect from INSERT in INSERT FROM SELECT.  #229, #223 - @vlanse
* [FIXED] SQLServer dialect: support prepared statements with TOP.  #230, #225 - @vlanse
* [ADDED] IsPrepared to SQLExpression interface.  #231 - @vlanse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlanse @doug-martin