Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nil valuer #255 #277

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

benzolium
Copy link
Contributor

I've just copy-pasted #256 but added a simple test. Feel free to copypaste my test and merge original solution.

@benzolium
Copy link
Contributor Author

@doug-martin, could you please take a look? I still have to use fork. :(

@doug-martin doug-martin reopened this Jul 27, 2021
@doug-martin
Copy link
Owner

Closed and reopened to run tests

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #277 (ee6a5ed) into master (ff08a24) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #277   +/-   ##
=======================================
  Coverage   96.77%   96.78%           
=======================================
  Files          60       60           
  Lines        3319     3324    +5     
=======================================
+ Hits         3212     3217    +5     
  Misses         91       91           
  Partials       16       16           
Flag Coverage Δ
unittests 96.78% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sqlgen/expression_sql_generator.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff08a24...ee6a5ed. Read the comment docs.

@doug-martin doug-martin merged commit 61587fb into doug-martin:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants