Feat/support file sending #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement file sending logic - When botpress_response type is 'file' or 'image' or 'video' - Downloads the file from the url in disk - And then sends it to chatwoot - Enable chatwoot file type identification by mime type - Using the MimeMagic gem and the file_path - Create temp_files folder - To store the files downloaded from the url - Create functions: - response_image? - response_file? - response_video? - download_file - Rename functions: - 'botpress_response_choise_options?' -> 'response_choice_options?' - Also correcting typo in the name - build_choise_options_body -> build_choice_options_body - Only correcting typo in the name - Add mimemagic dependency - Add byebug as a development/test dependency - Add some files/folders in .gitignore - files in temp_files folder - .byebug_history file - .idea folder
- Refactor download_file function to save file in memory - Refactor the file sending logic to use the new download_file function - Unified request_url variable to url variable - Create get_file_name_by_url function - Remove mimemagic gem - File class objects already have a content_type method - Remote temp_files folder - Remove temp_files folder from .gitignore
- Separate send file logic from SendToChatwoot into a new class - SendFileToChatwootRequest - Add some Rails loggers into SendFileToChatwootRequest
- Create SendFileToChatwootRequestTest:
- Test SendFileToChatwootRequest get_file_name_by_url function:
- 'should return valid file name'
- 'should throw invalid file name error'
- Add tests in ChatwootControllerTest:
- 'should send image'
- 'should send video'
- 'should send file'
- 'should send file with message'
- In SendFileToChatwootRequest:
- Make the form_data content optional
- Fix use case response by transforming the status code into string
- Add a try...catch to download_file function
- Add in get_file_name_by_url function a validation
- If not valid throw an error
- In ReceiveEvent:
- Capture each of the chatwoot responses
- To return at use case response
- Add test files in fixtures:
- image-file.png
- pdf-file.pdf
- video.file.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.