Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detect model by swapping around 1pl and 2pl #26

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

frankier
Copy link
Contributor

@frankier frankier commented Jun 4, 2021

This makes MaxInfoSelector behave as specified for 2pl models.

@douglasrizzo douglasrizzo merged commit e9fa1be into douglasrizzo:dev Jun 5, 2021
@douglasrizzo
Copy link
Owner

Thanks. I believe that, alongside what was addressed in #23, we can close #23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants