Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to shut down the Listener #21

Open
jfmesse opened this issue Feb 9, 2021 · 1 comment
Open

No way to shut down the Listener #21

jfmesse opened this issue Feb 9, 2021 · 1 comment

Comments

@jfmesse
Copy link

jfmesse commented Feb 9, 2021

Occasionally processes need to be restarted, but the Listener class appears to expose no way of cleanly shutting down. Forcibly shutting down introduces a risk of losing messages that are still being processed by the client, but have been ack-ed by the listener immediately after entering the onMessage function.

Having better control of ack-ing would help, but having say a shutdown method on the Listener that could be called after an appropriate signal has been received would be ideal.

@zakagan
Copy link
Collaborator

zakagan commented Feb 10, 2021

I'll take a look at this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants