Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNASNS-2660] NodeJS stream client maintenance #44

Merged

Conversation

andres-e-paez-t
Copy link
Collaborator

@andres-e-paez-t andres-e-paez-t commented Oct 30, 2024

What does this PR do?

  • Upgrading the libraries used by the client
  • Solving the two issues on the project's issue tracker.

Where should the reviewer start?

You can start reading the new README.md file.

How should this be manually tested?

You can install and run the demo using an prod stream subscription.

Any background context you want to provide?

What are the relevant tickets?

DNASNS-2660
Received messages automatically ack-ed
No way to shut down the Listener

Screenshots

Questions

Checklist

  • I added the necessary documentation, if appropriate.
  • I added tests to prove that my fix is effective or my feature works.
  • I reviewed existing Pull Requests before submitting mine.

@andres-e-paez-t andres-e-paez-t changed the base branch from master to develop November 8, 2024 15:50
@andres-e-paez-t andres-e-paez-t marked this pull request as ready for review November 14, 2024 15:07
@andres-e-paez-t andres-e-paez-t merged commit 1f7987a into develop Nov 15, 2024
@andres-e-paez-t andres-e-paez-t deleted the feature/DNASNS-2660/nodejs-stream-client-maintenance branch November 15, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants