Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming credentials bug fix and documentation changes #2

Merged
merged 3 commits into from
Apr 27, 2018

Conversation

martellj
Copy link
Collaborator

This PR has two components:

  1. Fix a bug where the wrong streaming credentials URI is used when using userId and password

  2. Make documentation changes to illustrate use of service account Id or userId, clientId and password

@martellj martellj requested a review from dylanroy April 25, 2018 15:40
Copy link
Contributor

@dylanroy dylanroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Looks good

@dylanroy dylanroy merged commit 957925c into dowjones:master Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants