Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request : Add showDropdown prop to readme #144

Closed
SeunginLyu opened this issue Aug 6, 2018 · 4 comments
Closed

Feature Request : Add showDropdown prop to readme #144

SeunginLyu opened this issue Aug 6, 2018 · 4 comments

Comments

@SeunginLyu
Copy link

I wanted the dropdown-content to be rendered regardless of the dropdown-trigger status. (I wanted to see the tree on init bascially). I sort of did this by adding the showDropdown prop as I did below.

<DropdownTreeSelect showDropdown={true} data={treeData} onChange={onChange} onAction={onAction} onNodeToggle={onNodeToggle} />

Could you maybe add this prop to the documentation and perhaps add an option to make the dropdown-content to be always rendered and visible?

@mrchief
Copy link
Collaborator

mrchief commented Aug 7, 2018

I wasn't sure if there would be enough use cases to make showDropdown a supported prop, so I kind of toyed with it - which is why it's undocumented. I think it's safe to take it out of its beta phase (so to speak 😉 ) and make it documented.

Regarding the always visible, you can use showDropdown={true} in combination with CSS to keep it always visible - I'm assuming you don't want to show the toggle arrow in your case - so you can/should probably hide it via CSS anyway.

@mrchief
Copy link
Collaborator

mrchief commented Aug 7, 2018

If you want to, feel free to send a PR for the docs.

mrchief added a commit that referenced this issue Aug 14, 2018
mrchief added a commit that referenced this issue Aug 14, 2018
mrchief added a commit that referenced this issue Aug 14, 2018
* fix: Do not toggle dropwdown on pill removal (#141) 🐛

* fix: Show partial select with empty children (#139) 🐛

* fix: Fix outside click in case of multiple dropdowns

* docs: Add showDropdown prop description to readme (#152)

Closes #144
mrchief added a commit that referenced this issue Aug 14, 2018
* fix: Do not toggle dropwdown on pill removal (#141) 🐛

* fix: Show partial select with empty children (#139) 🐛

* fix: Fix outside click in case of multiple dropdowns

* docs: Add showDropdown prop description to readme (#152)

Closes #144
mrchief added a commit that referenced this issue Aug 14, 2018
* fix: Do not toggle dropwdown on pill removal (#141) 🐛

* fix: Show partial select with empty children (#139) 🐛

* fix: Fix outside click in case of multiple dropdowns

* docs: Add showDropdown prop description to readme (#152)

Closes #144
@mrchief
Copy link
Collaborator

mrchief commented Aug 14, 2018

🎉 This issue has been resolved in version 1.12.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SeunginLyu
Copy link
Author

Wow, thank for adding this feature. Appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants