fix: clear search input on resetting state #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1482
💛 - Coveralls |
berdyshev
changed the title
|
@mrchief please check |
|
Will check and let you know. |
|
@all-contributors Please add @berdyshev for code,bug |
|
I couldn't determine any contributions to add, did you specify any contributions? |
|
@all-contributors Please add @berdyshev for code and bug |
|
I've put up a pull request to add @berdyshev! 🎉 |
mrchief
approved these changes
Aug 9, 2020
|
Code Climate has analyzed commit a1a462b and detected 0 issues on this pull request. View more on Code Climate. |
|
🎉 This PR is included in version 2.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
m4theushw
pushed a commit
to m4theushw/react-dropdown-tree-select
that referenced
this pull request
Sep 20, 2020
Co-authored-by: Hrusikesh Panda <mrchief@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using both
clearSearchOnChangeandinlineSearchInputoptions, the search input is not cleared inside the opened dropdown upon selecting one of the search results.We need to check whether the input ref is accessible but not the case when
inlineSearchInputis not set.Fixes #409