Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added missing prop 'inlineSearchPlaceholder' in 'TextProps' interface #434

Merged
merged 2 commits into from
Oct 11, 2020

Conversation

eduardohley
Copy link
Contributor

What does it do?

Adds a missing prop in TextProps interface inside 'react-dropdown-tree-select.d.ts' according to the docs.

Type of change

  • [ x ] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • [ x ] Updated documentation (if applicable)
  • [ ] Added tests that prove my fix is effective or that my feature works
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] My changes generate no new warnings

Note

This is a previous pull request with verified commits

@coveralls
Copy link

coveralls commented Oct 10, 2020

Pull Request Test Coverage Report for Build 1521

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.901%

Totals Coverage Status
Change from base Build 1515: 0.0%
Covered Lines: 598
Relevant Lines: 619

💛 - Coveralls

@codeclimate
Copy link

codeclimate bot commented Oct 10, 2020

Code Climate has analyzed commit aa7bad7 and detected 0 issues on this pull request.

View more on Code Climate.

@mrchief mrchief merged commit 3db87c9 into dowjones:develop Oct 11, 2020
@github-actions
Copy link

🎉 This PR is included in version 2.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

m4theushw pushed a commit to m4theushw/react-dropdown-tree-select that referenced this pull request Feb 6, 2021
m4theushw pushed a commit to m4theushw/react-dropdown-tree-select that referenced this pull request Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants