Skip to content

Commit

Permalink
Deprecate Python 3.6, to keep inline with supported versions (#92)
Browse files Browse the repository at this point in the history
  • Loading branch information
pcmxgti authored and sevignyj committed Dec 16, 2022
1 parent a152723 commit c7c3503
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.6', '3.7', '3.8', '3.9', '3.10', '3.11']
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Generate temporary AWS credentials via Okta.
.. image:: https://github.com/dowjones/tokendito/workflows/Lint%20and%20Test/badge.svg
:target: https://github.com/dowjones/tokendito/actions

.. image:: https://img.shields.io/badge/python-3.6%2C%203.7%2C%203.8%2C%203.9%2C%203.10-blueviolet
.. image:: https://img.shields.io/badge/python-3.7%2C%203.8%2C%203.9%2C%203.10%2C%203.11-blueviolet
:target: https://pypi.org/project/tokendito/

.. image:: https://github.com/dowjones/tokendito/workflows/Woke/badge.svg
Expand Down Expand Up @@ -36,7 +36,7 @@ Use tokendito to generate temporary AWS credentials via Okta for programmatic au
Requirements
------------

* Python 3.6+
* Python 3.7+
* Your AWS account is federated in Okta

tokendito is compatible with python 3, and can be installed with either pip or pip3.
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.black]
line-length = 100
target-version = ['py36', 'py37', 'py38', 'py39', 'py310', 'py311']
target-version = ['py37', 'py38', 'py39', 'py310', 'py311']

[tool.coverage.report]
exclude_lines = [
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
beautifulsoup4>=4.6.0
botocore>=1.12.36
platformdirs>=2.4.0 # This can be bumped after Python 3.6 is deprecated.
platformdirs>=2.5.4
requests>=2.19.0
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"Intended Audience :: End Users/Desktop",
"Intended Audience :: Developers",
"Intended Audience :: System Administrators",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
Expand All @@ -57,7 +56,7 @@
],
keywords=["okta", "aws", "sts"],
packages=find_packages(exclude=["contrib", "docs", "tests", ".tox"]),
python_requires=">=3.6",
python_requires=">=3.7",
license=about["__license__"],
zip_safe=False,
install_requires=[required],
Expand Down
6 changes: 3 additions & 3 deletions tests/unit_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@ def test_prepare_duo_info():
"verification": {
"_links": {
"complete": {"href": "http://test.okta.href"},
"script": {"href": "python-v3.6"},
"script": {"href": "python-v3.7"},
},
"signature": "fdsafdsa:fdsfdfds:fdsfdsfds",
"host": "test_host",
Expand All @@ -957,7 +957,7 @@ def test_prepare_duo_info():
"parent": f"{config.okta['org']}/signin/verify/duo/web",
"host": "test_host",
"sid": "",
"version": "3.6",
"version": "3.7",
}
assert prepare_duo_info(selected_okta_factor) == expected_duo_info

Expand All @@ -977,7 +977,7 @@ def test_get_duo_sid(mocker):
"parent": f"{config.okta['org']}/signin/verify/duo/web",
"host": "test_host",
"sid": "",
"version": "3.6",
"version": "3.7",
}

test_url = "http://test.token.dito?sid=testval"
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
skipsdist = true
envlist = lint, py{36,37,38,39,310,311}, auth, coverage
envlist = lint, py{37,38,39,310,311}, auth, coverage

[testenv]
deps = -r requirements-dev.txt
Expand Down Expand Up @@ -30,11 +30,11 @@ commands =

[gh-actions]
python =
3.6: py36
3.7: py37
3.8: py38
3.9: py39
3.10: py310
3.11: py311

[flake8]
max-line-length = 100
Expand Down

0 comments on commit c7c3503

Please sign in to comment.