Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Push + Number Challenge #109

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Support Push + Number Challenge #109

merged 1 commit into from
Jan 30, 2023

Conversation

pcmxgti
Copy link
Contributor

@pcmxgti pcmxgti commented Jan 23, 2023

Description

This introduces the ability to display the numerical challenge that can be part of a push challenge.

Related Issue

This addresses the lack of functionality referenced in #107

Motivation and Context

Okta introduced a "Number Challenge" feature that can be combined with a push to enhance security. This may be present in all AUTHn calls, some, or none, depending on the configuration for the Okta Organization.

How Has This Been Tested?

Tested locally with tox and manually against a non-production Okta instance

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pcmxgti pcmxgti force-pushed the feat/number_challenge branch from 63da248 to 89e5d35 Compare January 24, 2023 21:38
@pcmxgti pcmxgti marked this pull request as ready for review January 24, 2023 21:45
Copy link
Contributor

@sevignyj sevignyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sevignyj sevignyj merged commit 215e397 into main Jan 30, 2023
@sevignyj sevignyj deleted the feat/number_challenge branch January 30, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants