Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Docker builds #116

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Support Docker builds #116

merged 2 commits into from
Feb 28, 2023

Conversation

pcmxgti
Copy link
Contributor

@pcmxgti pcmxgti commented Feb 23, 2023 •
edited
Loading

  • Simplify .dockerignore
  • Update dependency with CVE
  • Fixed EOFError on running with no arguments
  • Added tests
  • Updated documentation
  • Added build / push process to .github/

Description

Create a workflow to build and publish Docker images.

Related Issue

#112

How Has This Been Tested?

locally, with tox

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pcmxgti pcmxgti force-pushed the chore/docker_build branch 5 times, most recently from 104c828 to 705e9a5 Compare February 24, 2023 17:08
@pcmxgti
Support experimental Docker builds
8f13c89 
* Simplify .dockerignore
* Update dependency with CVE
* Fixed EOFError on running with no arguments
* Added tests
* Updated documentation
* Added build / push process to .github/
@pcmxgti pcmxgti marked this pull request as ready for review February 24, 2023 17:45
@pcmxgti pcmxgti requested a review from sevignyj February 27, 2023 22:31
@sevignyj sevignyj merged commit 72e5615 into main Feb 28, 2023
@sevignyj sevignyj deleted the chore/docker_build branch February 28, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevignyj sevignyj sevignyj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcmxgti @sevignyj