Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with SAML document without assertions #125

Merged
merged 1 commit into from
May 21, 2023
Merged

Conversation

pcmxgti
Copy link
Contributor

@pcmxgti pcmxgti commented May 20, 2023

Description

Fix issue with SAML document without assertions

Related Issue

Motivation and Context

Fixes a problem where a misconfigured tile could break scanning for
all roles. This small change skips tiles that do not have any roles,
and exits gracefully if no roles are available at all.

How Has This Been Tested?

locally, and with tox

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Fixes a problem where a misconfigured tile could break scanning for
all roles. This small change skips tiles that do not have any roles,
and exits gracefuly if no roles are available at all.
@pcmxgti pcmxgti marked this pull request as ready for review May 20, 2023 22:55
@pcmxgti pcmxgti requested a review from sevignyj May 20, 2023 22:55
@sevignyj sevignyj merged commit b232885 into main May 21, 2023
@pcmxgti pcmxgti deleted the fix/bad_tile branch September 17, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants