Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow to build multiarch signed images to docker hub #127

Merged
merged 1 commit into from
Jun 16, 2023
Merged

workflow to build multiarch signed images to docker hub #127

merged 1 commit into from
Jun 16, 2023

Conversation

sevignyj
Copy link
Contributor

@sevignyj sevignyj commented Jun 13, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@sevignyj sevignyj marked this pull request as ready for review June 13, 2023 02:44
@sevignyj sevignyj requested a review from pcmxgti June 13, 2023 02:44
@sevignyj sevignyj force-pushed the fix/build_and_sign branch 2 times, most recently from 2235708 to 587dd53 Compare June 16, 2023 01:33
@sevignyj sevignyj force-pushed the fix/build_and_sign branch from 587dd53 to 5c8e620 Compare June 16, 2023 01:36
pcmxgti
pcmxgti approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@pcmxgti pcmxgti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thank you for putting this together.

@pcmxgti pcmxgti merged commit 162209e into main Jun 16, 2023
@pcmxgti pcmxgti deleted the fix/build_and_sign branch June 16, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmxgti pcmxgti pcmxgti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevignyj @pcmxgti