OIE implementation, with authorization code flow . #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevignyj
force-pushed
the
feature/oie
branch
3 times, most recently
from
3ba6eae to
9de3d7c
Compare
|
This is great. Looking forward to this implementation. |
sevignyj
force-pushed
the
feature/oie
branch
7 times, most recently
from
e38ffbe to
590ad2d
Compare
sevignyj
force-pushed
the
feature/oie
branch
9 times, most recently
from
2a97bce to
ffcd43c
Compare
sevignyj
force-pushed
the
feature/oie
branch
4 times, most recently
from
bfdb4a3 to
332b6df
Compare
sevignyj
force-pushed
the
feature/oie
branch
2 times, most recently
from
bba74dc to
f6e9c4f
Compare
sevignyj
force-pushed
the
feature/oie
branch
3 times, most recently
from
2329cf8 to
4df1952
Compare
sevignyj
force-pushed
the
feature/oie
branch
6 times, most recently
from
dc3b22c to
b6c8dd7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pcmxgti
reviewed
Nov 14, 2023
There was a problem hiding this comment.
The code flow looks good. I left some inline comments for you to review what makes sense to keep, and what to remove or clean up.
Some important notes to keep in mind:
- put back the version dependency for
certifi - clean up the duplicate arguments
- rebase and squash (if not already done)
- update README to reference Okta OIE support forcing Classic mode
sevignyj
force-pushed
the
feature/oie
branch
from
3708285 to
1506b8d
Compare
sevignyj
changed the title
sevignyj
force-pushed
the
feature/oie
branch
3 times, most recently
from
d0be3c3 to
d3e8b0d
Compare
tokendito/okta.py
Dismissed
| payload = {"username": config.okta["username"], "password": config.okta["password"]} | ||
|
|
||
| logger.debug(f"Authenticate user to {config.okta['org']}/api/v1/authn") | ||
| logger.debug(f"Sending {headers}, {payload} to {config.okta['org']}/api/vi/authn") |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
There was a problem hiding this comment.
config.okta["password"] is masked.
sevignyj
force-pushed
the
feature/oie
branch
2 times, most recently
from
a9eb3f3 to
a3ea3f8
Compare
sevignyj
force-pushed
the
feature/oie
branch
2 times, most recently
from
c3b794c to
c045e89
Compare
sevignyj
changed the title
sevignyj
changed the title
sevignyj
force-pushed
the
feature/oie
branch
from
c045e89 to
6e43114
Compare
pcmxgti
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: