Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure location of tests #138

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Restructure location of tests #138

merged 1 commit into from
Oct 18, 2023

Conversation

pcmxgti
Copy link
Contributor

@pcmxgti pcmxgti commented Oct 17, 2023 •
edited
Loading

Description

Move tests into separate files

Motivation and Context

This change put tests for each module into separate files, so that they are easier to extend.

How Has This Been Tested?

End-to-end, locally with tox, and comparing coveralls coverage reports pre/post #138

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 17, 2023
View reviewed changes
tests/unit/test_user.py Dismissed Show resolved Hide resolved
@pcmxgti
Refactor location of tests
8cccd04 
Organize file structure following Pytest best practices, and separate
tests into different files.
@pcmxgti pcmxgti force-pushed the fix/refactor_unit_tests branch from e51a652 to 8cccd04 Compare October 17, 2023 17:26
@pcmxgti pcmxgti changed the title Restructure test Restructure location of tests Oct 17, 2023
@pcmxgti pcmxgti marked this pull request as ready for review October 17, 2023 17:41
@sevignyj sevignyj merged commit 8084d45 into main Oct 18, 2023
22 checks passed
@pcmxgti pcmxgti deleted the fix/refactor_unit_tests branch October 18, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevignyj sevignyj sevignyj approved these changes

@fsilvamaia fsilvamaia Awaiting requested review from fsilvamaia

Assignees

@sevignyj sevignyj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcmxgti @sevignyj