Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DUO testability #139

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Improve DUO testability #139

merged 5 commits into from
Nov 14, 2023

Conversation

pcmxgti
Copy link
Contributor

@pcmxgti pcmxgti commented Oct 25, 2023 •
edited
Loading

Description

  • Modify duo_api_post() to use HTTP_client.
  • Improve the quality and quantity of tests for the DUO module.
  • Rename duo-specific functions for better readability.

This pull request does not improve or modify the logic for calling the DUO endpoint.

How Has This Been Tested?

End-to-end, with tox, and against the DUO API.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pcmxgti pcmxgti marked this pull request as ready for review November 9, 2023 16:52
sevignyj
sevignyj approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@sevignyj sevignyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sevignyj sevignyj merged commit 14db725 into main Nov 14, 2023
22 checks passed
@pcmxgti pcmxgti deleted the fix/duo branch November 14, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevignyj sevignyj sevignyj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcmxgti @sevignyj